search

ue4plugins / VlcMedia

Media Framework plug-in using the Video LAN Codec (libvlc).
BSD 3-Clause "New" or "Revised" License
267 stars 143 forks source link

Green bar at the bottom of certain videos #25

Closed gmpreussner closed 7 years ago

gmpreussner commented 7 years ago

Some videos show a green bar at the bottom.

The problem is that VLC sometimes allocates buffers that are larger than the display dimensions of the video. Buffer dimensions and display dimensions are separate concepts. The media framework API does not currently support this, and it expects both to be the same.

gmpreussner commented 7 years ago

Mentioned in https://github.com/ue4plugins/VlcMedia/issues/17

gmpreussner commented 7 years ago

I'm going to address this as part of the timecode related refactor for 4.15. Since we cannot clamp the sampling of the buffer (render device specific), I think we need to clamp the buffer in a shader instead, similar to what we're doing in PS4Media.

gmpreussner commented 7 years ago

This will be fixed in the UE4 Master branch on Wednesday 10/26

gmpreussner commented 7 years ago

This is fixed starting with https://github.com/ue4plugins/VlcMedia/commit/ce06cafb60dc11a4202636230515d6f2dec8cf01

(requires 4.15 code, which isn't on Github yet - will be merged up November 23rd)