uebelack / python-maxcube-api

A python api to control the Max! Cube thermostats.
https://github.com/uebelack/python-maxcube-api
MIT License
21 stars 26 forks source link

Fix ignoring zeros in rf_address #5

Closed blocktrron closed 7 years ago

blocktrron commented 7 years ago

Under some circumstances, the rf_address is not correctly parsed. In case the rf_address of a device would contain zeros in hex-notation, the zeros would be ignored.

EG: A device id "DE A0 EF" would become "DE AE F" and "D0 F0 EF" would become "DF EF"

uebelack commented 7 years ago

Hi, thanks for your contribution! could you please fix the failing tests so i can merge your pull request?

Thanks,

David

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 98.182% when pulling 9a20bdfb6e4df3cd6e466dba8a01691bc42a54c8 on blocktrron:master into ee0a77d88c46d789bfd47fc30b1bf4287ff86402 on goodfield:master.