Wall stat temp is actually 9 bits with the 9th bit being the topmost bit of byte 8

uebelack / python-maxcube-api

A python api to control the Max! Cube thermostats.

https://github.com/uebelack/python-maxcube-api

MIT License

21 stars 26 forks source link

Wall stat temp is actually 9 bits with the 9th bit being the topmost bit of byte 8 #8

Closed phil-lavin closed 6 years ago

phil-lavin commented 7 years ago

This broke if the temperature went over 256 (25.6c) - it reported a really low temperature. The docs were also wrong on this - they said it was the topmost bit of byte 7. I have pull requested a fix there too: https://github.com/Bouni/max-cube-protocol/pull/34

coveralls commented 7 years ago

Coverage remained the same at 98.842% when pulling ef9294a0d41fdd5dcab7142248ab0d41b8adece1 on phil-lavin:bugfix-wall-stat-temp into 9458b66cd8291355d5c8feee6b00c12d010ad6d9 on goodfield:master.