search

ueberauth / guardian

Elixir Authentication
MIT License
3.44k stars 381 forks source link

Relax phoenix dependency to 1.3 #295

Closed maxnordlund closed 7 years ago

maxnordlund commented 7 years ago

Phoenix 1.3 has a release candidate, and it would be nice if you could use Guardian with it. I don't think there should be any problems, as it's Plug based, but it's hard to tell until you've tried it for real.

Thoughts?

doomspork commented 7 years ago

@maxnordlund please see one of the many issues on Phoenix 1.3 where this has been discussed: https://github.com/ueberauth/guardian/issues/288

maxnordlund commented 7 years ago

Ah, thanks.

maxnordlund commented 7 years ago

All though, considering the amount of issues I found, it might be good to relax the constraint anyways.

doomspork commented 7 years ago

There's no plan to do that @maxnordlund but thank you. Issues like this come up when using Elixir all the time, it's important to handle it the proper way (as mentioned in those issues) and not force packages to loosen their dependencies.

maxnordlund commented 7 years ago

True, but from what I could tell by reading through those issues, there seem to be no issue with using Guardian with 1.3. Anyway, sooner or later it will be released and then this can be properly dealt with.

doomspork commented 7 years ago

Thanks @maxnordlund 👍