Adding halt to the error pipeline

ueberauth / guardian

Elixir Authentication

MIT License

3.44k stars 381 forks source link

Closed uzarubin closed 7 years ago

uzarubin commented 7 years ago

This PR solves #401 by adding halt() to verify_header.ex and verify_session.ex

doomspork commented 7 years ago

@hassox any objections before I merge?

uzarubin commented 7 years ago

I don't use session auth, but I noticed that that file also had the same issue? I can fix that if it's actually a problem.

doomspork commented 7 years ago

@uzarubin let's fix that as part of this too 👍

uzarubin commented 7 years ago

@doomspork done.

hassox commented 7 years ago

LGTM Nice catch! :)