search

ueberauth / guardian

Elixir Authentication
MIT License
3.44k stars 381 forks source link

Fix Guardian compilation when Plug is not being use #415

Closed yordis closed 7 years ago

yordis commented 7 years ago

https://github.com/ueberauth/guardian/blob/708f924806995c749c6c27c3c93dab76fc212bde/lib/guardian/permissions/bitwise.ex#L371 for some reason that line is not actually doing what we expect and the compilation of Guardian fails if there is no Plug module

V1 related

Hanspagh commented 7 years ago

So its seems likeCode.ensure_loaded only work on module level. I propose to move the permission plug to Guardian.Plug.Permission, this however is a breaking change. What do you think about this? First draft here: https://github.com/Hanspagh/guardian/tree/fix-ensure-loaded

Hanspagh commented 7 years ago

Fixed by #404