codecov-io commented 5 years ago

Codecov Report

Merging #543 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #543   +/-   ##
=======================================
  Coverage   85.19%   85.19%           
=======================================
  Files          18       18           
  Lines         412      412           
=======================================
  Hits          351      351           
  Misses         61       61

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3c91f9f...bbe03e3. Read the comment docs.

yordis commented 5 years ago

@doomspork meh, I would do it since major packages are using Jason by default

asummers commented 5 years ago

Re: discussion from offline, the discussion was to add a toggle between Poison and Jason.... But taking a look through the code, this is all just a test dependency, so there's absolutely no reason to add that =) Instead, removing Jason AND Poison from runtime dependencies is the way to go here.

      {:jason, "~> 1.1", only: [:dev, :test], runtume: [:false]},

yordis commented 5 years ago

@asummers 🎉 🎉 🎉 🎉 🎉 🎉

ueberauth / guardian

Remove Poison from dependencies, replace with Jason in :dev, :test #543

Codecov Report