search

ueberauth / guardian

Elixir Authentication
MIT License
3.43k stars 382 forks source link

Fix dialyzer errors and add to build process. #544

Closed asummers closed 5 years ago

asummers commented 5 years ago

Guardian.t() wasn't a thing, and I wasn't sure what it was supposed to be, searching the code for similar types. So I just made it say module.

codecov-io commented 5 years ago

Codecov Report

Merging #544 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #544   +/-   ##
=======================================
  Coverage   85.19%   85.19%           
=======================================
  Files          18       18           
  Lines         412      412           
=======================================
  Hits          351      351           
  Misses         61       61
Impacted Files Coverage Δ
lib/guardian/phoenix/socket.ex 93.33% <ø> (ø) :arrow_up:
lib/guardian/permissions/bitwise.ex 90.9% <ø> (ø) :arrow_up:
lib/guardian/plug.ex 82.6% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a271ea5...526c553. Read the comment docs.

asummers commented 5 years ago

Just a quick bump on these and my other open ones, seeing if there's anything preventing them from bring merged.

doomspork commented 5 years ago

@yordis I'm pretty sure we can release with a rc package, we just don't want to do that for things like Phoenix where people will expect a new release with every rc. It's quickly a slippery slop with some dependencies.

asummers commented 5 years ago

Had to change the cache slightly. Now it's super fast. 11-13m down to 1.5m.

asummers commented 5 years ago

I have a branch locally branched off this that bumps Credo and fixes the issues, so I can open that pursuant to this being merged.

doomspork commented 5 years ago

@asummers are you on Elixir Slack? We all lurk on #ueberauth if you ever want to come through and discuss potential changes.

We're always looking to add motivated folks to the team 😁