search

ueberauth / guardian

Elixir Authentication
MIT License
3.43k stars 382 forks source link

Update credo rules and remove GPlug and friends aliases. #551

Closed asummers closed 5 years ago

asummers commented 5 years ago

Also removes the {}'d aliases and prefers separate aliases which can be alphabetized.

If any of these are desired to be restored to their former glory, I can for sure do that on a case by case / class by class basis, or separate into separate PRs, but I think these are generally "good changes".

codecov-io commented 5 years ago

Codecov Report

Merging #551 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #551   +/-   ##
=======================================
  Coverage   85.19%   85.19%           
=======================================
  Files          18       18           
  Lines         412      412           
=======================================
  Hits          351      351           
  Misses         61       61
Impacted Files Coverage Δ
lib/guardian/token/jwt.ex 85.36% <ø> (ø) :arrow_up:
lib/guardian.ex 90% <ø> (ø) :arrow_up:
lib/guardian/permissions/bitwise.ex 90.9% <ø> (ø) :arrow_up:
lib/guardian/plug.ex 82.6% <ø> (ø) :arrow_up:
lib/guardian/plug/load_resource.ex 86.66% <100%> (ø) :arrow_up:
lib/guardian/plug/pipeline.ex 86.36% <100%> (ø) :arrow_up:
lib/guardian/plug/verify_header.ex 69.56% <100%> (ø) :arrow_up:
lib/guardian/plug/verify_cookie.ex 91.3% <100%> (ø) :arrow_up:
lib/guardian/plug/verify_session.ex 94.44% <100%> (ø) :arrow_up:
lib/guardian/phoenix/socket.ex 93.33% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1fb14fb...9fc6770. Read the comment docs.