search

ueberauth / guardian

Elixir Authentication
MIT License
3.43k stars 382 forks source link

Improves Guardian.Token.Verify.verify_literal_claims function #558

Closed jsangilve closed 5 years ago

jsangilve commented 5 years ago

Solves #555

yordis commented 5 years ago

@jsangilve amazing ❤️ I left some comments, also the CI is failing.

codecov-io commented 5 years ago

Codecov Report

Merging #558 into master will increase coverage by 0.2%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #558     +/-   ##
=========================================
+ Coverage   85.37%   85.57%   +0.2%     
=========================================
  Files          18       18             
  Lines         417      423      +6     
=========================================
+ Hits          356      362      +6     
  Misses         61       61
Impacted Files Coverage Δ
lib/guardian/token/verify.ex 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0c3e8ee...e4cfff0. Read the comment docs.

jsangilve commented 5 years ago

Thx @yordis. I improved verify_literal_claims removing the filtering step and putting everything within a reduce.

CI was failing because of formatting on verify_test. Shouldn't happen anymore.

jsangilve commented 5 years ago

@yordis done

jsangilve commented 5 years ago

@yordis, Do you guys want something else here or is it ready to be merged? Thx