ueberauth / guardian

Elixir Authentication
MIT License
3.44k stars 381 forks source link

Consumer Project Dialyzer Failing on master #562

Closed asummers closed 5 years ago

asummers commented 5 years ago

After this commit,

def remember_me_from_token(conn, token, claims \\ %{}, opts \\ []),
  do: Guardian.Plug.remember_me_from_token(conn, token, claims, opts)

calls into

@spec remember_me_from_token(
        Plug.Conn.t(),
        module,
        Guardian.Token.token(),
        Guardian.Token.claims(),
        Guardian.options()
      ) :: Plug.Conn.t()
def remember_me_from_token(conn, mod, token, claims_to_check \\ %{}, opts \\ []) do
  # ... 
end

which does not type check for projects that call use Guardian.

asummers commented 5 years ago

Note that simply re-adding implementation() does not work for some reason. There's a deeper issue here somewhere.