ueberauth / guardian

Elixir Authentication

MIT License

3.43k stars 382 forks source link

Expand Travis config #567

Closed doomspork closed 5 years ago

yordis commented 5 years ago

@doomspork don't we agree on be responsible only for the last 2 versions of Elixir and OTP?

In this case, 1.7 and 1.8

doomspork commented 5 years ago

Removed

yordis commented 5 years ago

It seems that there is a mismatch betwen Elixir version and supported OTP version

yordis commented 5 years ago

I would say remove the matrix and do the following config

elixir:
  - 1.7
  - 1.8

otp_release:
  - 21.1
  - 21.2

doomspork commented 5 years ago

@yordis for my own edification can you explain how you figured that out? Reading the Travis logs it looks like Dialyzer took too long. Each of the apps built just fine.

==> guardian
Compiling 20 files (.ex)
Generated guardian app
mix format --check-formatted
mix credo --strict
Checking 20 source files ...
Please report incorrect results: https://github.com/rrrene/credo/issues
Analysis took 2.6 seconds (0.05s to load, 2.6s running checks)
309 mods/funs, found no issues.

....

Generated phoenix app
==> guardian
Compiling 23 files (.ex)
warning: no configuration found for otp_app :guardian and module Guardian.Phoenix.SocketTest.Endpoint
Generated guardian app
..........................................................................................................................................................
Finished in 2.2 seconds
154 tests, 0 failures

The failure:

Adding 929 modules to dialyzer.plt
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received

The build has been terminated

codecov-io commented 5 years ago

Codecov Report

Merging #567 into master will decrease coverage by 0.06%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #567      +/-   ##
==========================================
- Coverage   85.57%   85.51%   -0.07%     
==========================================
  Files          18       18              
  Lines         423      421       -2     
==========================================
- Hits          362      360       -2     
  Misses         61       61

Impacted Files	Coverage Δ
lib/guardian/permissions/bitwise.ex	`90.47% <0%> (-0.44%)`	:arrow_down:
lib/guardian/plug.ex	`83.56% <0%> (-0.23%)`	:arrow_down:
lib/guardian/token/jwt/verify.ex	`100% <0%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 599fa12...c5940a2. Read the comment docs.