search

ueberauth / guardian

Elixir Authentication
MIT License
3.43k stars 382 forks source link

Elixir 1.8 deprecations #569

Closed garretttaco closed 5 years ago

garretttaco commented 5 years ago

The release of Elixir v1.8.0 comes with a few hard deprecations. I noticed that one in particular is being used in this library.

[System] :seconds, :milliseconds, etc. as time units is deprecated in favor of :second, :millisecond, etc.

doomspork commented 5 years ago

@garretttaco thanks for bringing this to our attention. A PR to fix these would be greatly appreciated 😁

garretttaco commented 5 years ago

@doomspork I will get to it as soon as I can! Things are swamped at work but I figured I would at least bring it to others' attention.

sjoconnor commented 5 years ago

I just ran into this as well, but it looks like this has already been fixed here https://github.com/ueberauth/guardian/pull/557 and is available in v1.2.1.

garretttaco commented 5 years ago

@sjoconnor Awesome, I did not see that. I upgraded and it appears to have fixed the issue. Thanks for pointing that minor version update. Since this is solved, I am closing this issue.