barthez commented 5 years ago

Hey,

I noticed that dialyzer complains about supertype of success specification of generated implementation/0 function in generated (...).Plug module:

Type specification 'Elixir.MyApp.Guardian.Plug':implementation() -> module() is a supertype of the success typing: 'Elixir.MyApp.Guardian.Plug':implementation() -> 'Elixir.MyApp.Guardian'

There is only 1 known value returned from that function, so we can also put it in function specification.

codecov-io commented 5 years ago

Codecov Report

Merging #571 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #571   +/-   ##
=======================================
  Coverage   85.57%   85.57%           
=======================================
  Files          18       18           
  Lines         423      423           
=======================================
  Hits          362      362           
  Misses         61       61

Impacted Files	Coverage Δ
lib/guardian/plug.ex	`83.78% <ø> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8930f7b...4644e14. Read the comment docs.

doomspork commented 5 years ago

Sorry @barthez, I missed your PR and fixed this via another merge.

ueberauth / guardian

Fix dialyzer warning in Guardian.Plug #571

Codecov Report