ueberauth / guardian

Elixir Authentication
MIT License
3.43k stars 382 forks source link

Broken links in tutorial.. token documentation, implementation module docs, pipeline guide, etc #577

Closed freqn closed 5 years ago

freqn commented 5 years ago

Broken links in tutorial.. token documentation, implementation module docs, pipeline guide, etc

Hanspagh commented 5 years ago

Hi @freqn could you provide the url of the broken links?

freqn commented 5 years ago

Certainly (My apologies for not doing so yesterday)!

Broken Tutorial Links

Token Documentation: https://github.com/ueberauth/guardian/blob/master/guides/tutorial/tokens-start.html

Implementation Module Docs: https://github.com/ueberauth/guardian/blob/master/guides/tutorial/introduction-implementation.html

Callbacks Link: https://github.com/ueberauth/guardian/blob/master/guides/tutorial/Guardian.html#callbacks

Pipeline Guide: https://github.com/ueberauth/guardian/blob/master/guides/tutorial/plug-pipeline.html

Guardian.Plug.EnsureAuthenticated: https://github.com/ueberauth/guardian/blob/master/guides/tutorial/Guardian.Plug.EnsureAuthenticated.html

Hanspagh commented 5 years ago

Thank you. This is actually because the guides are being generated to be viewed on hexdoc. We will find a way to make this more obvious or fix the links on github

freqn commented 5 years ago

Ah, that makes sense. Glad to help!