search

ueberauth / guardian

Elixir Authentication
MIT License
3.43k stars 382 forks source link

Update getting started tutorial to phoenix 1.4 #580

Closed LouisDelbosc closed 5 years ago

LouisDelbosc commented 5 years ago

I went through the getting started with the last phoenix version and got into some minor troubles. Here the code modification I had to operate for my code to work.

Thank you for your work :)

codecov-io commented 5 years ago

Codecov Report

Merging #580 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #580   +/-   ##
=======================================
  Coverage   85.51%   85.51%           
=======================================
  Files          18       18           
  Lines         421      421           
=======================================
  Hits          360      360           
  Misses         61       61

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 715e9a9...a31f547. Read the comment docs.

Hanspagh commented 5 years ago

Hi, would you mind telling what kind of trouble you had? The changes are fine, but {:bcrypt_elixir, "~> 2.0"} requires Erlang 20, which should be okay, but I would still be happy to know what was not working.