search

ueberauth / guardian

Elixir Authentication
MIT License
3.43k stars 382 forks source link

Fix error messages #584

Closed yordis closed 5 years ago

yordis commented 5 years ago

Related to #578

@ueberauth/developers I need your feedback on this, we currently send an error tuple to the clients with a text body containing that error tuple.

Should I send a human-readable message in this case?

I can fix this but I need your direction on what the proper fix for this is.

doomspork commented 5 years ago

I see no point in returning a tuple as a string. We should probably just be sending the reason.

yordis commented 5 years ago

@doomspork actually we call auth_error from AuthErrorHandler module so, should I send an atom instead of a string?

yordis commented 5 years ago

@doomspork @Hanspagh let's do this on #585