search

ueberauth / guardian

Elixir Authentication
MIT License
3.43k stars 382 forks source link

578 Fix error message #589

Closed yordis closed 5 years ago

doomspork commented 5 years ago

@yordis looks good, you need to rebase 👍

yordis commented 5 years ago

@doomspork now I remember why I didn't finish with this ticket.

For what it happening right now, it seems that previous tests weren't actually working as expected, there were all failing about the claim but since the expectations were generic we didn't cut it.

Can you confirm this?

doomspork commented 5 years ago

@yordis it appears to be a formatter issues on Travis:

** (Mix) mix format failed due to --check-formatted.
The following files were not formatted:
  * /home/travis/build/ueberauth/guardian/test/guardian/permissions/permissions_test.exs
make: *** [testing] Error 1
The command "make testing" exited with 2.
yordis commented 5 years ago

Sorry, I forgot to push the formatted version.

doomspork commented 5 years ago

Closing in favor of #590