moxley commented 5 years ago

Made some fixes to the SessionController example. The calls to Guardian.Plug.* didn't have the correct arguments.

Renamed the "secret" resource to "protected", to clarify the meaning.

Changed the "logout" endpoint to be an http GET. While POST may be technically more correct, GET is easier to implement.

Changed the Phoenix flash type from :success to :info, because :info is one of the types that come pre-configured.

codecov-io commented 5 years ago

Codecov Report

Merging #592 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #592   +/-   ##
=======================================
  Coverage   86.12%   86.12%           
=======================================
  Files          21       21           
  Lines         418      418           
=======================================
  Hits          360      360           
  Misses         58       58

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5663cfa...0dc5451. Read the comment docs.

yordis commented 5 years ago

@moxley 🚀

ueberauth / guardian

Fix controller example. Change route resource name. #592

Codecov Report