search

ueberauth / guardian

Elixir Authentication
MIT License
3.43k stars 382 forks source link

Change `clear_remember_me` to put an immediately expiring cookie #596

Closed futpib closed 5 years ago

futpib commented 5 years ago

(instead of just removing an existing one from the response)

Fixes #595

codecov-io commented 5 years ago

Codecov Report

Merging #596 into master will increase coverage by 0.06%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #596      +/-   ##
==========================================
+ Coverage   86.15%   86.22%   +0.06%     
==========================================
  Files          21       21              
  Lines         419      421       +2     
==========================================
+ Hits          361      363       +2     
  Misses         58       58
Impacted Files Coverage Δ
lib/guardian/plug.ex 84% <100%> (+0.43%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5965dfe...bbd13e3. Read the comment docs.

Hanspagh commented 5 years ago

Thank you for work @futpib, looks good to me. This should not be a breaking change since the old implementation assumed the user would clear the cookie them self