ueberauth / guardian

Elixir Authentication
MIT License
3.43k stars 382 forks source link

Implement using option `secret_fetcher` #601

Closed Sgoettschkes closed 5 years ago

Sgoettschkes commented 5 years ago

As discussed in #599, currently the secret_fetcher option which can be passed to Guardian.decode_and_sign isn't taken into account when choosing the secret fetcher.

I added a test to verify this bug and implemented the reading of this option value in the fetch_secret_fetcher function.

ToDos:

I'd be happy to review any feedback and suggestions for improvement.

Sgoettschkes commented 5 years ago

Before I tackle the todos, could a contributor verify that I'm on the right path and that it's worth pursuing?

Hanspagh commented 5 years ago

Since this is better fixed by using different configs, I am closing this for now