search

ueberauth / guardian

Elixir Authentication
MIT License
3.43k stars 382 forks source link

Tutorial Fixes #615

Closed panbenson closed 4 years ago

codecov-io commented 4 years ago

Codecov Report

Merging #615 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #615   +/-   ##
=======================================
  Coverage   86.81%   86.81%           
=======================================
  Files          22       22           
  Lines         455      455           
=======================================
  Hits          395      395           
  Misses         60       60

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 741b6a3...60b5c24. Read the comment docs.

panbenson commented 4 years ago

Yes @yordis the phoenix generator created that function. I managed to get it running without errors using it however

On Thu, Oct 17, 2019 at 11:21 PM Yordis Prieto notifications@github.com wrote:

@yordis commented on this pull request.

In guides/tutorial/start-tutorial.md https://github.com/ueberauth/guardian/pull/615#discussion_r336307054:

@@ -102,7 +102,7 @@ defmodule AuthMe.UserManager.Guardian do end

def resource_from_claims(%{"sub" => id}) do

  • case UserManager.get_user(id) do
  • case UserManager.get_user!(id) do

Ahhhh I see why you want it, in that case, changing it to ! will no work thou.

Are you talking about Phoenix generator?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ueberauth/guardian/pull/615?email_source=notifications&email_token=ADTOK6NNCVHBON4OJEKZQNDQPETVJA5CNFSM4JCBRT72YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCIMUYXA#discussion_r336307054, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADTOK6IL64II5ZKCITGQQD3QPETVJANCNFSM4JCBRT7Q .

Hanspagh commented 4 years ago

Do you still want you other changes merged? @panbenson

panbenson commented 4 years ago

@Hanspagh yeah sure, if you find the changes helpful, as those points were places i needed to change!

Hanspagh commented 4 years ago

I have addeda bit more feedback

panbenson commented 4 years ago

cant be merged until @yordis approves requested changes 😭