ueberauth / guardian

Elixir Authentication
MIT License
3.43k stars 382 forks source link

Version change to 2.0 in README #621

Closed pikender closed 4 years ago

pikender commented 4 years ago

I am little confused but looks like a typo.

In mix.exs, the version is @version "2.0.0" so should we not use ~> 2.0 in Installation section now.

Installation section has ~> 1.2

# mix.exs

defp deps do
  [{:guardian, "~> 1.2"}]
end

Please ignore if I missed some hidden context here

codecov-io commented 4 years ago

Codecov Report

Merging #621 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #621   +/-   ##
=======================================
  Coverage   86.52%   86.52%           
=======================================
  Files          22       22           
  Lines         438      438           
=======================================
  Hits          379      379           
  Misses         59       59

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8fb16c9...af1278e. Read the comment docs.

yordis commented 4 years ago

Thank you!