search

ueberauth / guardian

Elixir Authentication
MIT License
3.43k stars 382 forks source link

The default for missing bits is empty list #625

Closed geofflane closed 4 years ago

geofflane commented 4 years ago

Zero as a default value was trying to be used in MapSet.new which is invalid The normal return type is a list of atoms, so an empty list seems appropriate

geofflane commented 4 years ago

This should fix #607

codecov-io commented 4 years ago

Codecov Report

Merging #625 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #625   +/-   ##
=======================================
  Coverage   86.52%   86.52%           
=======================================
  Files          22       22           
  Lines         438      438           
=======================================
  Hits          379      379           
  Misses         59       59
Impacted Files Coverage Δ
lib/guardian/permissions.ex 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 957f006...1c4ad0b. Read the comment docs.