ueberauth / guardian

Elixir Authentication

MIT License

3.43k stars 382 forks source link

Updated start-tutorial #629

Closed cgorshing closed 4 years ago

cgorshing commented 4 years ago

I was walking through the tutorial and came across some issues. Pretty simple stuff. Let me know if you have any questions around these changes.

Updated version of guardian

There isn't a get_user only a get_user! in the UserManager class

The changeset failed having %User{} ... lib/auth_me/user_manager/user.ex:17: User.__struct__/0 is undefined, cannot expand struct Use

The path for the code snippet was wrong (my first time through I created the file)

I updated the tests in the docs, this wasn't really an issue, but thought best to keep them consistent with what actually get generated.

codecov-io commented 4 years ago

Codecov Report

Merging #629 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #629   +/-   ##
=======================================
  Coverage   86.81%   86.81%           
=======================================
  Files          22       22           
  Lines         455      455           
=======================================
  Hits          395      395           
  Misses         60       60

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b62f961...27f197f. Read the comment docs.

doomspork commented 4 years ago

Thank you @cgorshing!

@Hanspagh I am going to pull the commit from #628, amend the change, and push it so @panbenson's commits and contribution get it but we unblock this PR and are able to incorporate Benson's changes :+1: