search

ueberauth / guardian

Elixir Authentication
MIT License
3.4k stars 381 forks source link

:crypto.hmac/3 undefined due to being deprecated --> Need to bump Jose to 1.11 #685

Closed fantypants closed 10 months ago

fantypants commented 2 years ago

Hello, Jose deps need to be bumped to 1.11 to fix the following:

Request: POST /login ** (exit) an exception was raised: ** (UndefinedFunctionError) function :crypto.hmac/3 is undefined or private (crypto 5.0.2) :crypto.hmac(:sha512, "Salt", "Key")

I can open a PR if needed.

Current: :jose, 1.8 Solution: :jose, 1.11

Hanspagh commented 2 years ago

Feel free to open a PR. This is only a problem for OTP-24 btw and you will need 1.11.2 :)

yordis commented 2 years ago

@ueberauth/developers any objection to changing the minimal requirements to be a bit higher?

yordis commented 10 months ago

Hey there, as https://github.com/ueberauth/.github/blob/master/SECURITY.md#elixir-and-erlangotp elixir v1.11 is the minimal that Elixir itself supports.

I am gonna close this one, you will need to upgrade to a higher version.