search

ueberauth / guardian

Elixir Authentication
MIT License
3.4k stars 381 forks source link

Ensure that badly-formatted tokens don't raise an exception #697

Closed giddie closed 2 years ago

giddie commented 2 years ago

It seems that JOSE likes to raise ArgumentErrors when it encounters badly-formatted tokens. Since Guardian returns an :ok | :error tuple when decoding tokens, it seems sensible to catch these exceptions where possible.

yordis commented 2 years ago

Hey peep, do you mind bumping the version of the package and adding a CHANGELOG entry as well?

yordis commented 2 years ago

Any clue why the CI is not running?

giddie commented 2 years ago

Nope, no idea :shrug:

dolfinus commented 2 years ago

Hi.

It's better to change version from 2.2.2 to 2.3.0, because this could cause backward compatibility issues.

yordis commented 2 years ago

@dolfinus blame me for that one, I will do my best the next time.