ueberauth / guardian_db

Guardian DB integration for tracking tokens and ensuring logout cannot be replayed.
MIT License
368 stars 87 forks source link

Release the ecto_sql version constraint #113

Closed GRoguelon closed 4 years ago

GRoguelon commented 4 years ago

The file mix.iex defines a version constraint on ecto_sql to: ~> 3.1.0 which prevents to use the latest version of ecto and ecto_sql.

I made the change on my fork and the test are green, I tried on a personal project and none problem to report.

The version changed because the command: mix deps.upgrade ecto_sql.

Let me know if I missed something.

codecov-io commented 4 years ago

Codecov Report

Merging #113 into master will increase coverage by 1.66%. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #113      +/-   ##
========================================
+ Coverage   78.33%    80%   +1.66%     
========================================
  Files           5      5              
  Lines          60     60              
========================================
+ Hits           47     48       +1     
+ Misses         13     12       -1
Impacted Files Coverage Δ
lib/mix/tasks/guardian_db.gen.migration.ex 100% <0%> (+6.25%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7c0b08c...a0403ce. Read the comment docs.

doomspork commented 4 years ago

Thank you @GRoguelon :grin:

GRoguelon commented 4 years ago

Thank you @GRoguelon 😁

My pleasure