search

ueberauth / guardian_db

Guardian DB integration for tracking tokens and ensuring logout cannot be replayed.
MIT License
367 stars 87 forks source link

make jti and aud required fields, since they are primary keys #121

Closed Hanspagh closed 3 years ago

Hanspagh commented 3 years ago

After seeing #120 I released we have to test that actually hit this case. So I decided to clean up the token module a bit up. I have changed jti and aud to be required fields since they are already primary keys and the insert actually hard fails if they are missing. Now we til hit our token_storage_failure. Let me know what you think

yordis commented 3 years ago

Run mix format to make CI to pass

Hanspagh commented 3 years ago

Sorry for that, should be done now

doomspork commented 3 years ago

@Hanspagh can you rebase on master now that Github actions are in that branch?

codecov-io commented 3 years ago

Codecov Report

Merging #121 (7f292b1) into master (57bc0fe) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #121   +/-   ##
=======================================
  Coverage   81.25%   81.25%           
=======================================
  Files           5        5           
  Lines          64       64           
=======================================
  Hits           52       52           
  Misses         12       12
Impacted Files Coverage Δ
lib/guardian/db/token.ex 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 57bc0fe...7f292b1. Read the comment docs.