ueberauth / guardian_db

Guardian DB integration for tracking tokens and ensuring logout cannot be replayed.
MIT License
368 stars 87 forks source link

Implement an ETS storage adapter #131

Closed doomspork closed 1 year ago

doomspork commented 3 years ago

This requires #129 is merged beforehand but this leverages those new changes and implements and ETS adapter in place for Ecto/DB storage.

cc @alexfilatov

yordis commented 3 years ago

@doomspork any updates? Would you like me to take ownership of it? If so, what is left?

doomspork commented 3 years ago

@yordis feel free to take this over and drive it across the finish line. I was waiting for an answer above on the error message but we should just make a sane decision and move forward.

alexfilatov commented 3 years ago

please let me know if I can help with anything @doomspork @yordis

doomspork commented 3 years ago

Thank you @alexfilatov! Would you mind giving this PR another thorough look through and review?

yordis commented 3 years ago

I am gonna be working over the weekend, but please feel free to take the lead for sure!

alexfilatov commented 1 year ago

the PR looks good to me, I can only approve here in the comments :) @yordis @aleDsz what do you think?

yordis commented 1 year ago

@alexfilatov working on it at the very moment!

yordis commented 1 year ago

@alexfilatov do you mind giving a +1, please verify latest version if you could