ueberauth / guardian_db

Guardian DB integration for tracking tokens and ensuring logout cannot be replayed.
MIT License
368 stars 87 forks source link

Feature/cleaning up #66

Closed yordis closed 6 years ago

yordis commented 7 years ago

@doomspork merge the other first,

Basically I add some parenthesis and also what do you think about the idea of separate between the genserver and the actual module?

yordis commented 6 years ago

@doomspork do you think is a good idea try to get this into 1.0? The worker would be GuardianDb.Token.SweeperServer

yordis commented 6 years ago

@hassox @scrogson @doomspork please notice that the genserver is doing nothing, it is just taking inputs and send it to the module that actually implements the behavior and then take the output and reseting the state of the genserver. This will keep clean/lean the genserver which it does nothing more than genserver stuff.

doomspork commented 6 years ago

@hassox / @scrogson want to take a peek at this? I think this is a good refactor but I'd love to get your thoughts before I merge 😀

doomspork commented 6 years ago

@yordis could you please rebase? We'll merge this and then release 👍

hassox commented 6 years ago

LGTM. Thanks @yordis