search

ueberauth / guardian_phoenix

A collection of helpers for when using Guardian with Phoenix
MIT License
45 stars 10 forks source link

Hard dependency on Phoenix 1.3.2 #4

Closed tmjoen closed 4 years ago

tmjoen commented 5 years ago 
Failed to use "phoenix" (versions 1.4.0 to 1.4.9) because
  guardian_phoenix (version 2.0.0) requires 1.3.2
  phoenix_live_reload (version 1.2.1) requires ~> 1.4
  mix.exs specifies ~> 1.4

Looks like an oversight in mix.exs: https://github.com/ueberauth/guardian_phoenix/blob/1d2664367ab617884c7964a97d623546a807aac3/mix.exs#L54

yordis commented 5 years ago

Definitely shouldn't be 1.3.2, but I am not sure about 1.4 Phoenix since they had some breaking changes.

Would you mind to take the lead testing it with Phoenix 1.4?

gil-air-may commented 5 years ago

Any news on this issue?

doomspork commented 5 years ago

@tmjoen or @gil-air-may have you had a chance to test this with 1.4?

@yordis we could release a patch version with the dep moved to 1.3. Thoughts?

yordis commented 4 years ago

Yeah, we could at least use ~> 1.3 instead

tmjoen commented 4 years ago

Seems to work fine with 1.4 in my app. I don't use Permissions though, so YMMV.

yordis commented 4 years ago

@tmjoen are you getting any warnings? I think we need to fix some warnings.

yordis commented 4 years ago

I released 2.0.1, using ~> 1.3 instead.

Let me know if that works or if I have to add ~> 1.4 as well