search

ueberauth / oauth2

An Elixir OAuth 2.0 Client Library
MIT License
749 stars 139 forks source link

Direct support for 'expires_at' key when constructing AccessToken #145

Closed sheharyarn closed 7 months ago

sheharyarn commented 5 years ago

Currently the AccessToken.new/1 method does not use the expires_at param if it is present in the given map, and only uses expires_in or expires. It is common to store access tokens in the DB, so when fetching them back and re-constructing the AccessToken struct it should Just Work™️.

This PR changes that to use expires_at when it is already present.

sheharyarn commented 5 years ago

@scrogson There seems to be a problem with the Travis builds. Can you manually restart the failing jobs or update the travis build matrix to install the correct versions?

yordis commented 2 years ago

@sheharyarn long time ... my apologies, trying to help.

Where does expires_at come from?

I searched for it on https://datatracker.ietf.org/doc/html/rfc6749#section-4.1.4 but I couldn't find it.

snackfart commented 2 years ago

any updates?

github-actions[bot] commented 9 months ago

This pull request has been automatically marked as "stale:discard". If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated!.

github-actions[bot] commented 7 months ago

Closing this pull request after a prolonged period of inactivity. If this issue is still relevant, please ask for this pull request to be reopened. Thank you!