search

ueberauth / oauth2

An Elixir OAuth 2.0 Client Library
MIT License
749 stars 139 forks source link

Handle nil response body properly #173

Closed nherzing closed 7 months ago

nherzing commented 1 year ago

It is possible for the body returned by Tesla.request to be nil. Currently, this raises because there is no matching case. This change adds support for handling a nil response from Tesla.

Aside: I attempted to write a client test but, frustratingly, Plug doesn't seem to support building a response with a nil body. Happy to add that test if someone knows how to do build the response with Plug. It smells like a bug in Plug to me.

yordis commented 1 year ago

Hey, my apologies. I have yet to take the time to improve the PR process for this package. Do you mind adding an entry to https://github.com/ueberauth/oauth2/blob/master/CHANGELOG.md and bumping the version following SemVer?

Thank you so much for your work and patience. My apologies.

github-actions[bot] commented 9 months ago

This pull request has been automatically marked as "stale:discard". If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated!.

github-actions[bot] commented 7 months ago

Closing this pull request after a prolonged period of inactivity. If this issue is still relevant, please ask for this pull request to be reopened. Thank you!