ueberauth / ueberauth

An Elixir Authentication System for Plug-based Web Applications
MIT License
1.61k stars 120 forks source link

Doc: adding ueberauth to the applications list is no longer necessary #117

Closed FractalWire closed 3 years ago

FractalWire commented 4 years ago

The doc mention both in the main repo and in the various strategy repos that you should add Ueberauth and its strategies to the applications list like so:

def application do
  # Add the application to your list of applications.
  # This will ensure that it will be included in a release.
  [applications: [:logger, :ueberauth]]
end

For recent version of Elixir, this is no longer necessary and will, in fact, cause an error difficult to understand.

The doc should be updated to mention this change.

https://elixirforum.com/t/error-dbconnection-when-running-mix-phx-server/22652/2 https://www.amberbit.com/blog/2017/9/22/elixir-applications-vs-extra_applications-guide/

doomspork commented 4 years ago

Hi @FractalWire would you mind submitting a PR?

FractalWire commented 4 years ago

Sure ;) https://github.com/ueberauth/ueberauth/pull/118

Hanspagh commented 3 years ago

Closed by #118