ueberauth / ueberauth_example

Example Phoenix application using Überauth for authentication
http://ueberauth-example.herokuapp.com
MIT License
220 stars 73 forks source link

Fix ueberauth_github sample. #60

Closed ramortegui closed 4 years ago

ramortegui commented 4 years ago

This PR updates the libraries related with ueberauth_github issue and solves https://github.com/ueberauth/ueberauth_example/issues/23

On heroku sample app: image

Locally I was able to reproduce it: image

After updating libraries: image

ramortegui commented 4 years ago

@doomspork great!. Any chance to re-deploy the heroku app? ( to test it ;) )

doomspork commented 4 years ago

@ramortegui it should be autodeploying now, just give it a few minutes to get there 😁

ramortegui commented 4 years ago

@doomspork I checked the app on heroku, and still isn't working. So, I deployed the master branch in heroku: https://warm-chamber-41439.herokuapp.com/ and I configure it using a custom oauth app. (see config below), and is working.

Screenshot from 2019-11-22 22-57-25

Could you check the github app? (credentials, urls, logs)

Thanks ;)

image

ramortegui commented 4 years ago

@doomspork any chance to look up the github app❓