search

ueberauth / ueberauth_example

Example Phoenix application using Überauth for authentication
http://ueberauth-example.herokuapp.com
MIT License
220 stars 73 forks source link

Update phoenix to 1.4.9 and change logout button to a regular link #61

Closed aleciavogel closed 3 years ago

aleciavogel commented 4 years ago

This started out with me stumbling across #54 and #49. I simply wanted to eliminate the logout form and use the link helper method with the method: :delete attribute, but apparently that doesn't work because the version of Phoenix for this project was so out of date.

So, down the rabbit hole I went.

I only had credentials for Google at my disposal, so if someone can double-check that the other authentication methods remain intact, that would be lovely.

Hope this helps!

yordis commented 4 years ago

Once CI is passing I will test it locally.

Thank you for the work, appreciated.

Hanspagh commented 4 years ago

Any news here or can we merge?

doomspork commented 4 years ago

@yordis any final thoughts on this?