ueberauth / ueberauth_example

Example Phoenix application using Überauth for authentication
http://ueberauth-example.herokuapp.com
MIT License
220 stars 73 forks source link

Missing step in README.md #69

Closed wribln closed 3 years ago

wribln commented 3 years ago

When attempting to run the sample code, there needs to be a 'mix ecto.create' step before attempting to start the phx.server. I don't understand why as the sample code does not seem to make use of a database. I am not sure if this is a missing piece of documentation or a piece of code needing adjustment.

Hanspagh commented 3 years ago

Hi @wribln This code is based on a basic phoenix example and therefore also starts an ecto Repo. Hence the need for ecto.create. You are right this is not used for anything at the moment. Feel free to add a pr either removing ecto or updating the docs. Hope this makes senes.

wribln commented 3 years ago

Hey, @Hanspagh thank you for your quick response. I think the ecto repo should be removed so people are not confused - but I am not sure if I am able to create a correct pr at this time (just learning Phoenix/Elixir/Ecto/...). If you can give me an easy hint, I will try. BR

Hanspagh commented 3 years ago

I think it might make sense to reduce the complexity.

wribln commented 3 years ago

PR #70 created.

wribln commented 3 years ago

PR merged.