search

ueberauth / ueberauth_facebook

Facebook OAuth2 Strategy for Überauth.
MIT License
77 stars 64 forks source link

Picture size improvments #31

Closed Hajto closed 6 years ago

Hajto commented 7 years ago

Added possibility to specify image_type option which is concatinated into query. Now if picture is fetched via profile_fields query it'll be value of image (only url).

Hajto commented 7 years ago

Thank you very much for reviewing my PR. I will look deeper into that after finals.

doomspork commented 7 years ago

Howdy @Hajto! Have you had a chance to address the feedback?

Hajto commented 7 years ago

I have bit of "underpants fire", I've applied most of the requests still trying to understand and apply proof.

doomspork commented 7 years ago

No worries @Hajto, we're happy to help! If you let us know where you're having issues maybe we can provide some suggestions?

Hajto commented 7 years ago

@hassox @doomspork I fixed few bugs I had and applied your comments. Thank you very much for your guidance. I surely did learn a lot.

doomspork commented 7 years ago

@Hajto I sincerely apologize that we lost track of this PR 😰. If you could rebase it I would be happy to merge 👍

Hajto commented 7 years ago

Done. It was my first rebase so please check whether it was done properly.

doomspork commented 7 years ago

@Hajto it doesn't look like it worked. Try something like this:

$ git remote add upstream git@github.com:ueberauth/ueberauth_facebook.git
$ git fetch --all
$ git rebase upstream/master