search

ueberauth / ueberauth_facebook

Facebook OAuth2 Strategy for Überauth.
MIT License
77 stars 64 forks source link

Allow client_id and client_secret to be computed on each callback #43

Closed agombault closed 5 years ago

agombault commented 6 years ago

In some case, we use differents Facebook app with the same backend. Usage of a module helps to compute client_id and client_secret on each callback depending of connections data.

doomspork commented 6 years ago

Thanks for the PR @agombault. We should think about how we want to implement this because this functionality could easily be applied to other providers. @ueberauth/developers thoughts on this approach?

yordis commented 6 years ago

@doomspork this is something that @scrogson and I were talking about.

Here is a feedback with this implementation,

You only allow client and secret config to be configurable but what happen if tomorrow I want to add for example, extra_fields to be configurable or any other settings.

We need to find a generic solution as I describe this needs on this ticket https://github.com/ueberauth/ueberauth/issues/51 and should be addressed here https://github.com/ueberauth/ueberauth/issues/61

@ueberauth/core just give me the directions on how we want to go with #51 and #61 and I can tackle even @arjan is interested on contribute.

yordis commented 5 years ago

@agombault ueberauth is getting a major refactoring that will allow you to configure everything better than we do it today.

Just a little patience since it is on development