search

ueberauth / ueberauth_facebook

Facebook OAuth2 Strategy for Überauth.
MIT License
77 stars 64 forks source link

updated for graph API 2.5 #5

Closed sibsibsib closed 8 years ago

sibsibsib commented 8 years ago

Made a small update which allows to specifically request profile fields. I found that facebook was only returning the name and ID. The change to their API is detailed here:

Fewer default fields for faster performance: To help improve performance on mobile network connections, we've reduced the number of fields that the API returns by default. You should now use the ?fields=field1,field2 syntax to declare all the fields you want the API to return.

https://developers.facebook.com/blog/post/2015/07/08/graph-api-v2.4/

I'd like to add some tests, but I'm not quite sure where to get started. Open to suggestiions.

doomspork commented 8 years ago

Thanks @sibsibsib, I only have one piece of feedback. Have you tried this out with the example app? If not I can give a whirl.

sibsibsib commented 8 years ago

I'll update based on your feedback, thanks.

I haven't tried on the test project, but it's working on my own

On Saturday, 5 December 2015, Sean Callan notifications@github.com wrote:

Thanks @sibsibsib https://github.com/sibsibsib, I only have one piece of feedback. Have you tried this out with the example app? If not I can give a whirl.

— Reply to this email directly or view it on GitHub https://github.com/ueberauth/ueberauth_facebook/pull/5#issuecomment-162242965 .

doomspork commented 8 years ago

Great. I'll give it a spin when you're done and we should be good to merge.

sibsibsib commented 8 years ago

made the change requested. Also had a chance to try out the example - everything seems to be working. You should verify just to make sure though :)

doomspork commented 8 years ago

Sorry for the delay @sibsibsib, this looks good to me. Thanks again! :+1: