Closed alejandrodevs closed 12 months ago
Do you mind adding a unit test for this? Thus far it makes sense
@yordis Great! I added the unit tests.
Please forgive me for asking the following (it is on my document across all the repos 😭)
Do you mind adding an entry to the CHANGELOG.md
and bumping the package version so it is easier to deploy?
No worries, happy to contribute a little bit in the package. Both things were done.
🚀 💜
Add the possibility to get the client secret from a module in order to rotate the secret at least every 6 months (which is a good practice) without the need to be changing the config or env var and restart the application. Similar to the implementation of ueberauth_apple: https://github.com/ueberauth/ueberauth_apple/blob/main/guides/getting-started.md#generating-the-client-secret
Configuration would look like this:
and then:
This does not affect to the current implementation, it is backwards compatible. What do you think? @yordis