search

ueberauth / ueberauth_google

Google OAuth2 Strategy for Überauth.
MIT License
166 stars 85 forks source link

Update authorize_url and token_url #13

Closed jochakovsky closed 8 years ago

jochakovsky commented 8 years ago

Update with up-to-date URLs from https://developers.google.com/identity/protocols/OAuth2WebServer

doomspork commented 8 years ago

@jochakovsky can you verify that we're using the token_url? I noticed we've also set it as a module attribute (which we use later in the code) here: https://github.com/ueberauth/ueberauth_google/blob/master/lib/ueberauth/strategy/google.ex#L12

jochakovsky commented 8 years ago

Looks like the two are actually unrelated - a bit confusing, so I changed the variable name in #14. I also verified that token_url is being used by changing it to a bogus value and observing that authentication fails.

doomspork commented 8 years ago

Thank you @jochakovsky 👍