ueberauth / ueberauth_google

Google OAuth2 Strategy for Überauth.
MIT License
164 stars 85 forks source link

Support more parameters for google OAuth access #23

Closed nburkley closed 7 years ago

nburkley commented 7 years ago

For a web application that needs to access a google account when the user is present (e.g. polling for analytics) the approval_prompt and access_type parameters are required.

See the docs for more details

This PR adds the ability to add these options to the request. I've slightly refactored how the opts are put together.

Let me know what you think and if there's anything I should change.

nburkley commented 7 years ago

This addresses https://github.com/ueberauth/ueberauth_google/issues/16.

Thanks @venkatd for posting your solution to this!

doomspork commented 7 years ago

This looks good @nburkley, thank you 👍

nburkley commented 7 years ago

Great, thanks for the quick merge!

venkatd commented 7 years ago

@nburkley @doomspork thanks implementing and getting it merged in!