ueberauth / ueberauth_google

Google OAuth2 Strategy for Überauth.
MIT License
164 stars 85 forks source link

update oauth deps #24

Closed fajarmf closed 7 years ago

fajarmf commented 7 years ago
doomspork commented 7 years ago

Thank you @fajarmf! I'll test this today to make sure we're good to go 👍

scrogson commented 7 years ago

This PR is relying on an unpublished version of OAuth2 and needs to wait on me completing that work: https://github.com/scrogson/oauth2/pull/70

kelostrada commented 7 years ago

also if we update this we will have to update all other strategies - facebook, github, etc, those which rely on oauth too. As far as I know, update from 0.8.0 to 0.9.0 shouldn't differ in anything in strategies code so I would opt for updating oauth2 to 0.8.0 for now. What's your opinion on this guys?

And one more thing - it should be pretty important to update this, because there was a fix in 0.7.0 for expires_at and at the moment facebook's strategy doesn't work correctly (I mean the field expires_at is calculated incorrectly).

scrogson commented 7 years ago

@kelostrada feel free to submit some PRs updating the other strategies to 0.8.0 (if you have the time). I'm pegged at the moment and won't be able to put in any time into this effort.

kelostrada commented 7 years ago

I'm working on it, but can you publish master as 0.8.1 to hex? It seems facebook doesn't work with 0.8.0, but on master there is a fix which makes it work. If you are not sure about version 0.9.0 for now then I would love at least 0.8.1 to be published, because without that it will be hard to unify all the solutions if some of them work and others do not... I already prepared them for github, google and facebook integrations. If I find more time I will prepare PRs for other libs too.

doomspork commented 7 years ago

@kelostrada / @scrogson — Can this be closed?

kelostrada commented 7 years ago

Yeah I think so. I mean if @fajarmf is fine with it, the other PR is just a copy of this with my minor modifications

fajarmf commented 7 years ago

Yup it's fine.