ueberauth / ueberauth_google

Google OAuth2 Strategy for Überauth.
MIT License
166 stars 85 forks source link

Oauth2 update #25

Closed kelostrada closed 7 years ago

kelostrada commented 7 years ago

Basing on forked @fajarmf PR #24, I created one that is prepared to use 0.8.0 version of oauth2 instead of a branched one.

fajarmf commented 7 years ago

this looks great.

kelostrada commented 7 years ago

Okay will do later today or tomorrow, I just figured that this way it's not hard-bound to 0.8.0 so people can still use 0.8.1 anyway.

scrogson commented 7 years ago

If you use 0.8.0 that will lock it to that version. If you use 0.8 then it will use >= 0.8.0 < 1.0.0

kelostrada commented 7 years ago

wouldnt it lock for 0.8.x? its ~> 0.8.0

scrogson commented 7 years ago

You may be right. I can't remember :)

doomspork commented 7 years ago

@scrogson are you okay with the change you requested? If so I'd like to merge and publish.

scrogson commented 7 years ago

👍