search

ueberauth / ueberauth_google

Google OAuth2 Strategy for Überauth.
MIT License
164 stars 85 forks source link

Upgrade/allow oauth2 to be 2.0 #67

Closed PragTob closed 5 years ago

PragTob commented 5 years ago

oauth2 was semi recently upgraded to 2.0 with a fix that seems important and relevant. Would be nice to also include that in a future release.

Also, thanks for the great library! :wave: :tada:

taj commented 5 years ago

hello @PragTob we will look into it! :) but you are welcome to contribute with PRs as well if you want!

PragTob commented 5 years ago

@tajchumber I can happily do a PR allowing OAuth 2.0 just not to sure about the details/specifics as I'm unsure if the "possibly backwards compatible" part applies to this lib or not.

The big PR seems to be this https://github.com/scrogson/oauth2/pull/131 which fixes https://github.com/scrogson/oauth2/issues/128 which is a security related issue.

edit: added a small PR not sure what kind of testing one would need t do for this though #68