search

ueberauth / ueberauth_google

Google OAuth2 Strategy for Überauth.
MIT License
166 stars 85 forks source link

Upgrade Ueberauth and Refactor CSRF State Logic #82

Closed greg-rychlewski closed 3 years ago

greg-rychlewski commented 3 years ago

Ueberauth 0.7.0 introduces automatic CSFR attack protection: https://github.com/ueberauth/ueberauth/pull/136. This conflicts with the current way that this library fetches the CSRF state parameter.

Ueberauth exposes helper functions to pull the state param from the correct location: https://hexdocs.pm/ueberauth/Ueberauth.Strategy.Helpers.html#with_state_param/2. I've replaced the current method with this helper.

I've also updated some of the tests to be compatible with the new CSRF protection.

yordis commented 3 years ago

Thank you so much for the support! Appreciate!