search

ueberauth / ueberauth_identity

A username/password Strategy for Überauth
MIT License
80 stars 21 forks source link

Jsonapi & nested attributes #17

Closed seanwash closed 7 years ago

seanwash commented 7 years ago

Hey there,

I'm currently building out an API that conforms to the Jsonapi.org specification. I noticed that we can account for a nested attribute like %{user => {email, password}, but in order to conform to the spec I need to be able to send attributes nested two levels deep, for example:

{
  "data": {
    "type": "users",
      "attributes": {
        "email": "sean@wash.com",
        "password": "secret"
      }
    }
}

I'd be happy to try to PR this, but I'm still pretty new to Elixir!

doomspork commented 7 years ago

This is a great idea @seanwash and it looks like @mikereinmiller took a stab at this in #18, your feedback on the PR is welcomed and encouraged 😀

seanwash commented 7 years ago

@doomspork @mikereinmiller thanks! I've busy at my day job, but I'll have a chance to check this out in the next couple of days!

doomspork commented 7 years ago

@seanwash I believe this has been addressed thanks to @mikereinmiller's PR