search

ueberauth / ueberauth_slack

Slack OAuth2 Strategy for Überauth
MIT License
23 stars 33 forks source link

updated oauth2 dependency to ~> 0.8.0 #16

Closed zkwentz closed 6 years ago

zkwentz commented 7 years ago

Fix for #15

nickcampbell18 commented 7 years ago

This is really helpful, thanks! What would it take to get this merged?

doomspork commented 6 years ago

@zkwentz could you rebase please? 😁

zkwentz commented 6 years ago

Will do @doomspork

zkwentz commented 6 years ago

FYI rebased, thanks for your review!

CC \ @doomspork @hassox @nickcampbell18

yordis commented 6 years ago

@zkwentz notice that there is a merge conflict still in the status of the PR Github show you that.

zkwentz commented 6 years ago

@yordis I think that's based on @hassox's review prior to the rebase.

zkwentz commented 6 years ago

@yordis apologies, I see now, new computer, didn't have upstream.

Resolving now.

zkwentz commented 6 years ago

Updated.

Not sure what travis is doing, don't recall seeing it prior to rebase changes made today.

doomspork commented 6 years ago

Don't worry about @zkwentz, configuration issue 👍